-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1993977: Bump to 0.11.0 #50
Conversation
Signed-off-by: paulfantom <pawel@krupa.net.pl>
Fix waiting for kind cluster in e2e tests
Setting a nil-value typed object in the `DelegatingAuthenticatorConfig` will cause the generic logic to still evaluate is as non-nil since Golang does not consider `(*type)(nil)` as `nil` in `== nil` comparison unless `type == nil`, too. This leads to a setup of an x509 authenticator that attempts to call `VerifyOptions` on a nil object.
Signed-off-by: paulfantom <pawel@krupa.net.pl>
.github/workflows: enable golangci-lint
Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
VERSION: fix v0.10.0
allow path patterns in --allow-paths and --ignore-paths
Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
*: cut v0.11.0 release
* release-0.11: CHANGELOG.md: add 0.10.0 release notes *: cut v0.11.0 release allow path pattern in --allow-paths and --ignore-paths examples: regenerate VERSION: fix v0.10.0 *: lint code .golangci: configure .github/workflows: enable golangci-lint Prevent panics on client-cert authenticated requests Fix waiting for kind cluster in e2e tests
/lgtm |
/lgtm I think that brancz#132 would deserve a bugzilla: a team configuring a service monitor with TLS client authentication but not passing the client CA file to kube-rbac-proxy would trigger a panic of kube-rbac-proxy. Though such a change wouldn't pass CI tests, it's not a nice user experience and hard to troubleshoot. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, s-urbaniak, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@paulfantom: This pull request references Bugzilla bug 1993977, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@paulfantom: This pull request references Bugzilla bug 1993977, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
1 similar comment
/bugzilla refresh |
@paulfantom: This pull request references Bugzilla bug 1993977, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@paulfantom: This pull request references Bugzilla bug 1993977, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@paulfantom: All pull requests linked via external trackers have merged: Bugzilla bug 1993977 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build kube-rbac-proxy-container-v4.9.0-202311250023.p0.g58e0929.assembly.stream for distgit kube-rbac-proxy. |
Signed-off-by: paulfantom pawel@krupa.net.pl
cc @s-urbaniak @raptorsun